Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[57978] Mobile: Scrolling quickly to the top or bottom will not show top or bottom on the first try #16880

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Oct 2, 2024

Ticket

https://community.openproject.org/projects/openproject/work_packages/57978/activity

What are you trying to accomplish?

On mobile browsers there were often two scrollbars causing parts of the application to be hidden.

What approach did you choose and why?

The height of the content was previously calculated with 100vh. On mobile however, the browser adress bar counts into that. Therefore all modern browers support dvh which ignores the adress bar.
This only happened now, because we had special mobile scrolling rules which I removed recently.

…ditional scrollbar when on mobile devices the adress bar is shown. The adress bar is part of the 100vh but not of 100dvh.
@HDinger HDinger added this to the 14.6.x milestone Oct 2, 2024
@mrmir mrmir removed the needs review label Oct 2, 2024
@mrmir mrmir self-requested a review October 2, 2024 12:56
Copy link
Contributor

@mrmir mrmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrmir mrmir merged commit 407a8d7 into release/14.6 Oct 2, 2024
12 checks passed
@mrmir mrmir deleted the bug/57978-mobile-scrolling-quickly-to-the-top-or-bottom-will-not-show-top-or-bottom-on-the-first-try branch October 2, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants